Перевести «не найдено» карточек на NotFoundException

CardsService (get/move/links/reminders) и CardMover бросают NotFoundException вместо null/CardResultDto(null,null)/Exists=false. CardMoveResultDto — только Error; эндпоинты без локальных 404-проверок.
2026-09-13 18:23:53 +03:00
parent a9bfecf9cc
commit d2d6b81aa0
12 changed files with 107 additions and 152 deletions
@@ -27,9 +27,16 @@ public sealed partial class CardsService
    /// </summary>
    /// <param name="cardId">Id карточки (<c>c_...</c>).</param>
    /// <returns>Карточка или null — строки нет (эндпоинт отвечает 404 «Карточка не найдена»).</returns>
-    public Task<CardDto?> GetCardAsync(string cardId, CancellationToken ct)
+    /// <summary>
+    /// Одна карточка по id.
+    /// </summary>
+    /// <param name="cardId">Id карточки (<c>c_...</c>).</param>
+    /// <returns>Карточка.</returns>
+    /// <exception cref="NotFoundException">Карточка не найдена.</exception>
+    public async Task<CardDto> GetCardAsync(string cardId, CancellationToken ct)
    {
-        return _store.GetCardAsync(cardId, ct);
+        return await _store.GetCardAsync(cardId, ct)
+            ?? throw new NotFoundException(CardEntityName, cardId);
    }


@@ -57,7 +64,7 @@ public sealed partial class CardsService
        CardDto? card = await _store.GetCardAsync(cardId, ct);
        if (card is null)
        {
-            return new CardResultDto(null, null);
+            throw new NotFoundException(CardEntityName, cardId);
        }

        if (card.Col == CardIds.Archive || card.Col == CardIds.Trash)
@@ -81,7 +88,10 @@ public sealed partial class CardsService
            await _mlClient.PushAsync(text, toCol, PushWeightUser, ct);
        }

-        return new CardResultDto(null, await _store.GetCardAsync(cardId, ct));
+        return new CardResultDto(
+            null,
+            await _store.GetCardAsync(cardId, ct)
+                ?? throw new NotFoundException(CardEntityName, cardId));
    }

    /// <summary>